Fix Radio and MultiCheckbox labels #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Radio and MultiCheckbox inputs to allow a working connection with labels via the "for" attribute.
|
Thank you for the fix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RadioandMultiCheckboxelements have multiple options to select from. On the original code, if anidattribute was defined to one of these element types, it would simply be set on the input of the 1st option, which meant that clicking on the labels of the remaining options would not select them, as there was no association between the twoHTMLelements using theforattribute on thelabelelement.This patch fixes this behaviour, simply by assigning the original
idattribute to the first option and then assigning a customidattribute to the remaining options, instead of removing it.PS:. Even though the fix was only implement in two files, I noticed that some parts of the code weren't following Zend's coding standards, so I ran the codesniffer fix script, resulting in many more files being changed.