Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Form): use dedicated getter for retrieving helpers in formRows helper #397

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

neilime
Copy link
Owner

@neilime neilime commented Jul 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #397 (401a68b) into main (b708307) will decrease coverage by 0.13%.
The diff coverage is 80.32%.

@@             Coverage Diff              @@
##               main     #397      +/-   ##
============================================
- Coverage     90.27%   90.14%   -0.14%     
- Complexity     1799     1831      +32     
============================================
  Files            94       94              
  Lines          4866     4919      +53     
============================================
+ Hits           4393     4434      +41     
- Misses          473      485      +12     
Impacted Files Coverage Δ
src/TwbsHelper/Form/View/Helper/FormRows.php 89.40% <80.00%> (-6.52%) ⬇️
src/TwbsHelper/View/OriginalHtmlAttributesSet.php 36.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b708307...401a68b. Read the comment docs.

@neilime neilime merged commit 4bafe8f into main Jul 21, 2022
@neilime neilime deleted the fix/phpstan-issues branch July 21, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant