Custom attributes to 'form', 'fieldset' and 'form-group' wrapper #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow using of custom attributes in 'form', 'fieldset' tags. Also added ability to add and use custom attributes to form groups.
DeepCode Report (#ea8e07)DeepCode analyzed this pull request. |
|
@syberon can you fix lint issues. Some phpunit tests will be usefull for this new feature. Thank you |
Unfortunately i can't write the tests. UPD: understand what issues did you means:) I don't working with travis before. I will try to modify code according travis recommendation. |
|
@syberon please check de CI failed logs : https://travis-ci.org/neilime/zf-twbs-helper-module/jobs/613821459 |
|
I has fixed all issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using of custom attributes in 'form', 'fieldset' tags. Also added ability to add custom attributes to form groups.