Migrates and simplifies factories #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lications Signed-off-by: Frank Brückner <[email protected]>
froschdesign
force-pushed
the
hotfix/migrate-factories
branch
2 times, most recently
from
75347b6 to
9cc537c
Compare
Signed-off-by: Frank Brückner <[email protected]>
froschdesign
force-pushed
the
hotfix/migrate-factories
branch
from
9cc537c to
a9b9dcb
Compare
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
============================================
+ Coverage 88.42% 88.54% +0.11%
+ Complexity 1157 1148 -9
============================================
Files 63 60 -3
Lines 3146 3126 -20
============================================
- Hits 2782 2768 -14
+ Misses 364 358 -6
Continue to review full report at Codecov.
|
neilime
reviewed
Oct 8, 2021
| $requestedName, | ||
| ?array $options = null | ||
| ) { | ||
| /** @var ModuleOptions $options */ |
|
Nice refactoring thank you @froschdesign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference for the form view helper factory:
https://docs.laminas.dev/laminas-servicemanager/configuring-the-service-manager/#mapping-multiple-service-to-the-same-factory
And the
TwbsHelper\Options\Factory\ModuleOptionsFactoryavoids the servicemanager interface to allow other DI containers in the future, I am thinking of Mezzio here.