Introduce a "jumpAllowed" attribute (default true) which controls gap… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-jumping. If this attribute is false, we'll prevent a given drag from jumping the gap in the SeekArc - if you drag beyond 0, it won't let you continue the drag around to 99, and vice versa. This feels much more natural/physical in some situations.
|
Thanks for the awesome library. We've been loving it but found that it felt a little weird when the user dragged the thumb "across the gap" jumping from 0 to 99, or vice versa. This PR adds a switch to optionally turn that behavior off, which can make it feel more natural. Try it out and let me know what you think. |
tuancoltech
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-jumping.
If this attribute is false, we'll prevent a given drag from jumping the gap in the SeekArc - if you drag beyond 0, it won't let you continue the drag around to 99, and vice versa. This feels much more natural/physical in some situations.
Also updated to latest gradle plugin to match latest Android Studio.