refactor log4j-jpa to use junit5 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
AlbaHerrerias
approved these changes
Oct 3, 2024
| public class ContextStackJsonAttributeConverterTest { | ||
| private ContextStackJsonAttributeConverter converter; | ||
|
|
||
| @Rule | ||
| public final ThreadContextStackRule threadContextRule = new ThreadContextStackRule(); |
There was a problem hiding this comment.
First time I see this ThreadContextStackRule into @UsingThreadContextStack 🫶 If you could document this in the wiki, that would be great, thanks!
There was a problem hiding this comment.
It is documented in the code, as a comment in the related file. Otherwise I would have done this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.]
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory