[Merge] sda-auth #700
Merged
[Merge] sda-auth #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbygdell
force-pushed
the
merge/sda-auth
branch
6 times, most recently
from
c763fc2
to
631ac15
Compare
pontus
reviewed
Mar 1, 2024
pontus
previously approved these changes
Mar 1, 2024
|
Remove |
Interesting that they came back after doing |
jbygdell
force-pushed
the
merge/sda-auth
branch
3 times, most recently
from
1274df8
to
13db979
Compare
MalinAhlberg
previously approved these changes
Mar 4, 2024
So we get proper indentation in the yaml config
#minor
Co-authored-by: Alex Aperis <[email protected]>
|
@aaperis and @MalinAhlberg can you please re-approve this one so it can be merged. |
aaperis
approved these changes
Mar 6, 2024
MalinAhlberg
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
Related to #14
Description
This PR merges
sda-authintosdaundercmd/authwith as few modifications as possible.authis added to the support service section of sda.mdChanges made to auth in this PR:
elixirterms with genericoidchelm chart version is bumped to
0.24.0forsda-svctag is bumped to
v0.3.0(hopefully the automated tag bump will work)What's missing is a test setup to be able to properly test the OIDC login flow, possible solution is to make use of the
ls-aai-mockfrom the GDI project.