Added example kubernetes yaml #39
Conversation
I hacked my way through figuring this out and thought it might be helpful to others. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 39.42% 39.42%
=======================================
Files 1 1
Lines 208 208
=======================================
Hits 82 82
Misses 121 121
Partials 5 5Continue to review full report at Codecov.
|
README.md
Outdated
| secret: ZXhhbXBsZS1hcHAtc2VjcmV0 | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service |
There was a problem hiding this comment.
Perhaps we should leave the service as an exercise for the reader? I feel like these things vary too much from company to company (i.e. some might use an ingress controller, others type: NodePort, others type: LoadBalancer) for an example to provide much illustration.
There was a problem hiding this comment.
Agreed. I haven't done a deep dive on your code to see if there was any issues with a cloud LB or doing something like SSL termination on an ingress controller. If it is a simple client / server model, and you see no issues with it, I think it makes sense to leave it up to the operator and just notate that.
README.md
Outdated
| mountPath: /cfg | ||
| dnsConfig: | ||
| nameservers: | ||
| - 8.8.8.8 # USING GOOGLE DNS FOR LOOKUPS |
There was a problem hiding this comment.
Is this something that commonly needs to be set? I don't think I've ever explicitly configured my pods' nameserver, but rather have let them use KubeDNS.
There was a problem hiding this comment.
I don't think it is common, but I ran into some funky things using an air-gapped k8s cluster. Ok with removing dnsConfig from the example. For the hostAliases / hostnames, I think it's worth leaving in. In my case, I had the hardest time getting kuberos pod to create an OIDC client (i/o time out). When it can't create the client, it crashes and the pod restarts (hard to find logs as it's flapping). I eventually updated the dex endpoint with a valid cert but not a public DNS record and the hostAliases "hack" fixed that.
There was a problem hiding this comment.
Sounds good - I agree there's value in the hostAliases.
README.md
Outdated
| @@ -112,6 +112,88 @@ If the `current-context` is set to the name of one of the clusters then the | |||
| `--context` argument may be omitted, and the cluster named by `current-context` | |||
| will be used. | |||
|
|
|||
| ## Kubernetes (example) | |||
There was a problem hiding this comment.
Perhaps title this "Deploying to Kubernetes"?
I hacked my way through figuring this out and thought it might be helpful to others. Thanks!