Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 1268-search-suggestions-system.js #2624

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

aadil42
Copy link
Contributor

@aadil42 aadil42 commented Jun 23, 2023

Solved search-suggestions-system in JS.

File(s) Added: 1268-search-suggestions-system.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/search-suggestions-system/submissions/977924742/

Solved search-suggestions-system in JS.
* @param {string} searchWord
* @return {string[][]}
*/
var suggestedProducts = function(products, searchWord) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Break down function to match O() complexity

products.sort(sortAsc); /* Time O(N * log(N) */
search(...);		/* Time O(......) */

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Look at Trie

/**
 * DFS - Trie
 * Time O(N * M) | Space O(N)
 * https://leetcode.com/problems/search-suggestions-system/
 * @param {string[]} products
 * @param {string} searchWord
 * @return {string[][]}
 */
var suggestedProducts = (products, searchWord) => new Trie()
    .buildTrie(products)
    .searchWord(searchWord);

class Node {
    constructor () {
        this.children = new Map();
        this.isWord = false;
    }
};

class Trie {
    constructor () {
        this.root = new Node();
    }

    buildTrie (products) {
        for (const word of products) {
            this.insert(word);
        }

        return this;
    }
    
    insert (word, { root: node } = this) {        
        for (const char of word.split('')) {
            const child = (node.children.get(char) ?? new Node());
            
            node.children.set(char, child);

            node = child;
        }

        node.isWord = true;
    }
    
    searchWord (searchWord, buffer = [], suggestions = []) {
        for (const char of searchWord.split('')) {
            const prefix = this.getPrefix(buffer, char);
            const words = this.getSuggestions(prefix);

            suggestions.push(words);
        }
        
        return suggestions;
    }

    getPrefix (buffer, char) {
        buffer.push(char);

        return buffer.join('');
    }
    
    getSuggestions (prefix, words = []) {
        const node = this.getPrefixNode(prefix);

        const isInvalidPrefix = (node === null);
        if (isInvalidPrefix) return words
        
        return this.search(node, prefix, words);
    }

    getPrefixNode (prefix, { root: node } = this) {
        for (const char of prefix.split('')) {
            const child = (node.children.get(char) ?? null);

            const isLeafNode = (child === null);
            if (isLeafNode) return null;

            node = child;
        }

        return node;
    }

    search (node, word, words) {
        const isBaseCase = (words.length === 3);
        if (isBaseCase) return words;

        if (node.isWord) words.push(word);

        return this.dfs(node, word, words);
    }

    dfs (node, word, words) {
        for (const char of this.getChars()) {
            const child = (node.children.get(char) ?? null);

            const isLeafNode = (child === null);
            if (isLeafNode) continue;
        
            this.search(child, (word + char), words);
        }

        return words;
    }

    getChars () {
        return new Array(26).fill()
            .map((_, index) => String.fromCharCode((index + 97)));
    }
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it's too much? I mean, I might be intimidating for some people. NeetCode solved it with binary-search that's how I solved it too. It was more concise that way. But, if you want, I can add this solution in addition to the binary-search one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trie is typically a better solution since for searching, suggestions, and prefix against words.
Also the complexity is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll implement that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aakhtar3, I added the trie solution. But I kept the binary-search solution for reference.

Added Trie solution in addition to binary-search.
@aakhtar3 aakhtar3 merged commit 76d4bc4 into neetcode-gh:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants