Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨🧪 Wire linters into the main CI workflow #1652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨🧪 Wire linters into the main CI workflow #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/quality.yml → .github/workflows/reusable-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@
name: "Quality"

on:
push:
branches:
- master
- nedbat/*
pull_request:
workflow_dispatch:
workflow_call:

defaults:
run:
Expand All @@ -21,10 +16,6 @@ env:
permissions:
contents: read

concurrency:
group: "${{ github.workflow }}-${{ github.ref }}"
cancel-in-progress: true

jobs:
lint:
name: "Pylint etc"
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/testsuite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ concurrency:
cancel-in-progress: true

jobs:
linters:
name: Quality
# Don't run linters if the branch name includes "-notests"
if: "!contains(github.ref, '-notests')"
uses: ./.github/workflows/reusable-quality.yml

tests:
name: "${{ matrix.python-version }} on ${{ matrix.os }}"
runs-on: "${{ matrix.os }}-latest"
Expand Down Expand Up @@ -94,6 +100,7 @@ jobs:
# The tests didn't run if the branch name includes "-notests"
if: "!contains(github.ref, '-notests')"
needs:
- linters
- tests
runs-on: ubuntu-latest
steps:
Expand Down