Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livejs to head for index and pyfile #1509

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nicain
Copy link

@nicain nicain commented Dec 19, 2022

Add livejs to so that coverage report automatically updates.

@nicain
Copy link
Author

nicain commented Dec 19, 2022

CI is stuck at an install error for windows; seems like this is unrelated to my code change:

  pypy3 run-test-pre: PYTHONHASHSEED='900'
  pypy3 run-test: commands[0] | python igor.py zip_mods
  pypy3 run-test: commands[1] | python setup.py --quiet build_ext --inplace
  pypy3 run-test: commands[2] | python -m pip install -q -e .
    error: subprocess-exited-with-error
    
    × Preparing editable metadata (pyproject.toml) did not run successfully.
    │ exit code: 32[21](https://github.com/nedbat/coveragepy/actions/runs/3734869969/jobs/6337439137#step:6:22)[22](https://github.com/nedbat/coveragepy/actions/runs/3734869969/jobs/6337439137#step:6:23)6505
    ╰─> [12 lines of output]
        running dist_info
        creating C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info
        writing C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\PKG-INFO
        writing dependency_links to C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\dependency_links.txt
        writing entry points to C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\entry_points.txt
        writing requirements to C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\requires.txt
        writing top-level names to C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\top_level.txt
        writing manifest file 'C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\SOURCES.txt'
        reading manifest file 'C:\Users\RUNNER~1\AppData\Local\Temp\pip-modern-metadata-fglx8huv\coverage.egg-info\SOURCES.txt'
        reading manifest template 'MANIFEST.in'
        no previously-included directories found matching 'doc\_build'
        no previously-included directories found matching 'doc\_spell'
        [end of output]

@nedbat
Copy link
Owner

nedbat commented Dec 20, 2022

Hi, thanks, I hadn't heard of livejs before. But I don't think I want to always use it in every HTML report. Maybe we can solve this similarly to extra_css? A setting that lets people specify extra scripts to include in the HTML? Then you could use livejs in your settings, and all of your HTML reports would include it.

What do you think?

@ProsperousHeart
Copy link
Contributor

@nicain any update for @nedbat ? This request is almost 6 months old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants