Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Expound #7

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Bump Expound #7

merged 1 commit into from
Jan 6, 2020

Conversation

vemv
Copy link
Contributor

@vemv vemv commented Dec 30, 2019 •
edited by thumbnail
Loading

Brief

Primarily aimed at delivering the supression of its boxed math warnings (bhb/expound#180)

Also, the Expound updates deliver various fixes/improvements (https://github.com/bhb/expound/blob/f938ceb15534f9bec169ca880744659497b29fdf/CHANGELOG.md)

QA plan

  • Bump Expound manually in speced.def
    • Suite should still pass
    • Reporting should still work / be readable

...that is exercised in https://circleci.com/gh/nedap/speced.def/253 (with dummy failing tests) which output you can check.

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

@vemv vemv force-pushed the bump-expound branch 2 times, most recently from 0d7d6e3 to 8844a56 Compare December 30, 2019 18:26
vemv
vemv commented Dec 30, 2019
View reviewed changes
src/nedap/utils/spec/api.cljc Outdated Show resolved Hide resolved
vemv added a commit to nedap/speced.def that referenced this pull request Dec 30, 2019
@vemv
Proof build for nedap/utils.spec#7
165590a
@vemv vemv marked this pull request as ready for review December 30, 2019 18:36
@vemv
Bump Expound
37f89b7 
Primarily aimed at delivering the supression of its boxed math warnings.

Also, the Expound updates deliver various fixes/improvements (https://github.com/bhb/expound/blob/f938ceb15534f9bec169ca880744659497b29fdf/CHANGELOG.md)
@vemv
Copy link
Contributor Author

vemv commented Jan 6, 2020

Thanks!

@vemv vemv merged commit a8c4b76 into master Jan 6, 2020
@vemv vemv mentioned this pull request Jan 8, 2020
Merged
7 tasks
@thumbnail thumbnail deleted the bump-expound branch January 8, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thumbnail thumbnail thumbnail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vemv @thumbnail