Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec-assertion-thrown? improvements #80

Open
3 tasks
thumbnail opened this issue Jun 7, 2019 · 0 comments
Open
3 tasks

spec-assertion-thrown? improvements #80

thumbnail opened this issue Jun 7, 2019 · 0 comments

Comments

@thumbnail
Copy link
Member

thumbnail commented Jun 7, 2019

Problem statement

Currently no cljs option exists for this assert expression and the impl isn't bound by specs.

Task

  • add check! around impl.spec-assertion-thrown?; note this issue in a previous attempt: Add spec-assertion-thrown? test helper #55 (comment)
  • A cljs equivalent.
  • Expand unit.nedap.utils.speced.spec-assertion to also span remaining spec format (e.g. ^{::speced/spec x})

Alternatives and comparison

  1. A pure-fn alternative which returns true/false and works within is
    • might be able to leverage thrown?
  2. An extension of cljs.test' assert-expr.
@thumbnail thumbnail transferred this issue from nedap/speced.def Aug 13, 2019
@thumbnail thumbnail transferred this issue from nedap/utils.spec Aug 13, 2019
vemv added a commit to nedap/utils.modular that referenced this issue Dec 28, 2019
there's an xxx, and a clj-only test

see nedap/speced.def#80
vemv added a commit that referenced this issue Dec 28, 2019
vemv added a commit that referenced this issue Dec 29, 2019
vemv added a commit that referenced this issue Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant