fix: Fix Touchable with href is still clickable if disabled

[rnike]

fix #2298

According to the implementation of View

react-native-web/packages/react-native-web/src/exports/View/index.js

Lines 106 to 107 in dc9ecfb

	if (props.href != null) {
	component = 'a';

div will be changed to a if props.href is provided, the a will be clickable no matter if props.disabled is true or not.

TouchableHighlight and TouchableOpacity are both using View as a base component

react-native-web/packages/react-native-web/src/exports/TouchableHighlight/index.js

Lines 164 to 165 in dc9ecfb

	return (
	<View

react-native-web/packages/react-native-web/src/exports/TouchableOpacity/index.js

Lines 123 to 124 in dc9ecfb

	return (
	<View

This PR will add pointerEvents="none" to the component if props.disabled is true in TouchableHighlight and TouchableOpacity to make them actually disabled.

Tested on the example app and also our app.

[necolas]

The issue is because the href is still followed by the browser, so ideally there'd be no href set when the element is disabled. However, that does either require each Touchable/Pressable component to put some conditional logic around href, or for View and Text to understand the concept of being disabled so that they can avoid setting href.

If we go with the pointerEvents solution, is the intent of your patch that the pointerEvents value could be overridden? I would have assumed we want it enforced, in which case we should place pointerEvents={disabled ? 'none' : null} after the {...rest} spread.

[rnike]

@necolas I'm letting pointerEvents be overridable in purpose because forcing it to none if disabled is going to change these components' behaviour. For example, someone who is currently using TouchableOpacity with pointerEvents will find it working otherwise after having this upgrade. But thinking it through again, this seems to be an over-design because after all pointerEvents is not available for Touchables, I'm changing it back to pointerEvents={disabled ? 'none' : undefined}(null is incompatible with propertiy pointerEvents ), thanks for the review.

[necolas]

This patch is included in the latest canary release: [email protected]