Fix 'yarn lint' output on cleanly cloned repos #2228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm opening the folder as a project.
58:6 warning React Hook useLayoutEffect has a missing dependency: 'targetListeners'. Either include it or remove the dependency array react-hooks/exhaustive-deps. Options would be to disable the linter on that line (as it should have no impact being a wrapped useRef) or to just add it to silence it. Took the latter approach as that way is consistent with the precedent set by `useResponderEvents\index.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two small commits:
First
Git ignore local .idea folders created by IDEA-based IDEs like WebStorm opening the folder as a project.
Second
Fix 'yarn lint' issue on clean repo clone:
Options considered would be to disable the linter on that line (as it should have no impact being a wrapped useRef) or to just add it to silence it. Took the latter approach as that way is consistent with the precedent set by
useResponderEvents\index.js.Sorry I bucketed these two fixes together. I will split the PRs if you like.