Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ellipsis issues for Text numberOfLines={1} #2193

Closed
wants to merge 3 commits into from

Conversation

parasharrajat
Copy link
Contributor

@parasharrajat parasharrajat commented Jan 10, 2022

  1. Revert commit 562db69 to fix ellipsis for <Text numberOfLines={1} />.
  2. Fix ellipsis for Safari via adding word-wrap: normal to text-oneline styles. Based on https://stackoverflow.com/a/56961220/7462668

Fixes #2186
Fixes #2111

@parasharrajat
Copy link
Contributor Author

Updated tests.

@parasharrajat
Copy link
Contributor Author

parasharrajat commented Jan 11, 2022

cc @necolas . Sorry for the ping.

@necolas necolas added this to the 0.17.x milestone Feb 7, 2022
@necolas necolas closed this in 79707ce Feb 17, 2022
@parasharrajat parasharrajat deleted the fix-ellipsis branch February 18, 2022 09:22
rnike pushed a commit to VeryBuy/react-native-web that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behaviour of numberOfLines={1} in Text numberOfLines=1 does not work on Safari
2 participants