[fix] Focus jumps between TextInputs #2163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
reviewed
Nov 8, 2021
| @@ -243,7 +243,8 @@ const TextInput: React.AbstractComponent< | |||
| } | |||
| if (selectTextOnFocus) { | |||
| // Safari requires selection to occur in a setTimeout | |||
| setTimeout(() => { | |||
| clearTimeout(TextInput.focusTimeout); | |||
| TextInput.focusTimeout = setTimeout(() => { | |||
There was a problem hiding this comment.
The timeout should be managed as a ref or callback instead of this approach
There was a problem hiding this comment.
If we used refs we'd only have access to this instance's timeout. But we need to clear a timeout created by another TextInput instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the property selectTextOnFocus to multiple TextInputs can cause the focus to jump between them indefinitely. This PR fixes the corresponding issue #2162.