Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'fbjs' dependency from 'react-native-web' #2333

Open
3 of 4 tasks
necolas opened this issue Jul 6, 2022 · 0 comments
Open
3 of 4 tasks

Remove 'fbjs' dependency from 'react-native-web' #2333

necolas opened this issue Jul 6, 2022 · 0 comments
Assignees
@necolas
Labels
needs: help project:react-native-web Issue associated with react-native-web

Comments

@necolas
Copy link
Owner

necolas commented Jul 6, 2022 •
edited
Loading

Is there an existing request?

  • I have searched for this request

Describe the feature request

This will help to modernize related code, reduce bundle size, and improve the clarity of code throwing errors.
@necolas necolas changed the title Remove fbjs dependency from 'react-native-web' Remove 'fbjs' dependency from 'react-native-web' Jul 6, 2022
@crathor crathor mentioned this issue Jul 8, 2022
Closed
@kyletsang kyletsang mentioned this issue Jul 8, 2022
Closed
necolas pushed a commit that referenced this issue Jul 8, 2022
@crathor @necolas
Replace fbjs canUseDom with inline module
8c365d9 
Close #2336
Ref #2333
necolas pushed a commit that referenced this issue Jul 8, 2022
@kyletsang @necolas
Replace fbjs performanceNow with performance.now
07feddf 
Close #2337
Ref ##2333
@necolas necolas added this to the 0.19: React 18 milestone Aug 26, 2022
@necolas necolas added the project:react-native-web Issue associated with react-native-web label Aug 26, 2022
@necolas necolas self-assigned this Aug 26, 2022
rnike pushed a commit to VeryBuy/react-native-web that referenced this issue Sep 13, 2022
@crathor @necolas
Replace fbjs canUseDom with inline module
baca2a2 
Close necolas#2336
Ref necolas#2333
rnike pushed a commit to VeryBuy/react-native-web that referenced this issue Sep 13, 2022
@kyletsang @necolas
Replace fbjs performanceNow with performance.now
0da7158 
Close necolas#2337
Ref #necolas#2333
@necolas necolas mentioned this issue Oct 27, 2022
Merged
9 tasks
@necolas necolas removed this from the 0.19: React 18 milestone Nov 2, 2022
@mateoguzmana mateoguzmana mentioned this issue Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@necolas necolas

Labels
needs: help project:react-native-web Issue associated with react-native-web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@necolas