Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: support height and width on source #10

Closed
necolas opened this issue Sep 8, 2015 · 3 comments
Closed

Image: support height and width on source #10

necolas opened this issue Sep 8, 2015 · 3 comments
Milestone
React Native 0.22

Comments

@necolas
Copy link
Owner

necolas commented Sep 8, 2015

If dimensions are provided they can be used to determine the aspect ratio and layout the Image before it is downloaded.
@necolas necolas modified the milestone: React Native 0.22 Mar 13, 2016
@necolas
Copy link
Owner Author

necolas commented Aug 27, 2016

I wonder if we could write an image loader that automatically includes this information for static assets, rather than just returning a URL string

@MoOx
Copy link
Contributor

MoOx commented Aug 27, 2016

I have thought about that too!
I have write some loaders, and I think it should be pretty easy to handle. We probably just need to find a nice npm package that helps to get width/height and use it :)

@necolas
Copy link
Owner Author

necolas commented Oct 23, 2016

The issue to create a new webpack loader is #237. Would appreciate someone taking it on.

necolas added a commit that referenced this issue Oct 24, 2016
@necolas
[change] Image 'source' dimensions and RN layout
0af6dc0 
Adds support for 'width' and 'height' set via the 'source' property.
Emulates RN image layout (i.e., no dimensions by default).

Fix #10
kidroca pushed a commit to kidroca/react-native-web that referenced this issue Mar 4, 2023
@flodnv
Merge pull request necolas#10 from rawalyogendra/exp-safari-viewport-fix
b364706 
Fix: Safari Keyboard open/close viewport height update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
React Native 0.22
Development

No branches or pull requests
2 participants
@MoOx @necolas