-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[change] whitelist props passed to React DOM
Avoiding unknown property warnings from React DOM. Many components within and build upon React Native do not filter their own properties and spread them into View. It is expected that React Native ignore these properties. Fix #898
- Loading branch information
Showing
2 changed files
with
81 additions
and
19 deletions.
There are no files selected for viewing
75 changes: 75 additions & 0 deletions
75
packages/react-native-web/src/exports/View/filterSupportedProps.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
const whitelist = { | ||
accessibilityComponentType: true, | ||
accessibilityLabel: true, | ||
accessibilityLiveRegion: true, | ||
accessibilityRole: true, | ||
accessibilityTraits: true, | ||
accessible: true, | ||
children: true, | ||
disabled: true, | ||
importantForAccessibility: true, | ||
onBlur: true, | ||
onContextMenu: true, | ||
onFocus: true, | ||
onMoveShouldSetResponder: true, | ||
onMoveShouldSetResponderCapture: true, | ||
onResponderEnd: true, | ||
onResponderGrant: true, | ||
onResponderMove: true, | ||
onResponderReject: true, | ||
onResponderRelease: true, | ||
onResponderStart: true, | ||
onResponderTerminate: true, | ||
onResponderTerminationRequest: true, | ||
onScrollShouldSetResponder: true, | ||
onScrollShouldSetResponderCapture: true, | ||
onSelectionChangeShouldSetResponder: true, | ||
onSelectionChangeShouldSetResponderCapture: true, | ||
onStartShouldSetResponder: true, | ||
onStartShouldSetResponderCapture: true, | ||
onTouchCancel: true, | ||
onTouchCancelCapture: true, | ||
onTouchEnd: true, | ||
onTouchEndCapture: true, | ||
onTouchMove: true, | ||
onTouchMoveCapture: true, | ||
onTouchStart: true, | ||
onTouchStartCapture: true, | ||
pointerEvents: true, | ||
style: true, | ||
testID: true, | ||
// escape-hatches for ScrollView | ||
onScroll: true, | ||
onWheel: true, | ||
// escape-hatches for Touchable keyboard support | ||
onKeyDown: true, | ||
onKeyPress: true, | ||
onKeyUp: true, | ||
// escape-hatches for creating hover effects | ||
onMouseEnter: true, | ||
onMouseLeave: true, | ||
onMouseMove: true, | ||
onMouseOver: true, | ||
onMouseOut: true, | ||
// unstable escape-hatches for web | ||
className: true, | ||
href: true, | ||
onClick: true, | ||
onClickCapture: true, | ||
rel: true, | ||
target: true | ||
}; | ||
|
||
const filterSupportedProps = props => { | ||
const safeProps = {}; | ||
for (const prop in props) { | ||
if (props.hasOwnProperty(prop)) { | ||
if (whitelist[prop] || prop.indexOf('aria-') === 0 || prop.indexOf('data-') === 0) { | ||
safeProps[prop] = props[prop]; | ||
} | ||
} | ||
} | ||
return safeProps; | ||
}; | ||
|
||
export default filterSupportedProps; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters