Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input[type="search"] documentation block #825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SiarheiBobryk
Copy link

@SiarheiBobryk SiarheiBobryk commented Sep 6, 2020

Changes in README.md:

  1. Remove notes about Chrome on macOS and Windows, because it's not
    reproduced. See attached images. Tested on macOS 10.15 and Windows 10/7.
  2. Remove notes about Safari on Windows, because it's completely
    out-of-date and not supported anymore by normalize.css. Safari 5.1.7
    was the last version supported by Windows XP/Vista/7.
    Safari version history

Changes below are required to cover all cases mentioned on README.md for
Safari.

Changes in test.html:

  1. Add some new styles:
    • font-family
    • background-color
  2. Add the value attribute

Changes in normalize.css:

  1. Fix comment about -webkit-appearance for Chrome

Screen Shot 2020-09-06 at 3 16 05 pm

Screen Shot 2020-09-06 at 3 24 29 pm

Changes in README.md:
1. Remove notes about Chrome on macOS and Windows, because it's not
reproduced. See attached images. Tested on macOS 10.15 and Windows 10/7.
2. Remove notes about Safari on Windows, because it's completely
out-of-date and not supported anymore by normalize.css. Safari 5.1.7
was the last version supported by Windows XP/Vista/7.
[Safari version history](https://en.wikipedia.org/wiki/Safari_version_history#Windows)

Changes below are required to cover all cases mentioned on README.md for
Safari.

Changes in test.html:
1. Add some new styles:
    - font-family
    - background-color
2. Add the value attribute
@SiarheiBobryk
Copy link
Author

@necolas up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant