Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SystemPackagingTask archive file config gradle 7 compatible #400

Conversation

breskeby
Copy link
Contributor

Using convention mapping has been deprecated in Gradle 7.1. This PR makes the task specific archive file configuration Gradle 7.1 compliant.

@breskeby
Copy link
Contributor Author

Anyone looking into this and has feedback? Would love to see that merged and published

@DanielThomas
Copy link
Contributor

Thanks for this @breskeby. Looks fine to me. @chali has been handling our Gradle 7 compatibility work, I'll leave it for him to merge so I don't step on his toes.

@rpalcolea rpalcolea merged commit 8d3a03b into nebula-plugins:master Aug 17, 2021
@rpalcolea
Copy link
Member

Hi @breskeby , thanks again for this change

8.6.1 is out and should contain both of your contributions

@breskeby
Copy link
Contributor Author

Awesome thanks!

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Aug 18, 2021
This updates the nebula ospackage plugin to 8.6.1 that includes
a our provided PRs:

- nebula-plugins/gradle-ospackage-plugin#402
- nebula-plugins/gradle-ospackage-plugin#400
- nebula-plugins/gradle-ospackage-plugin#397

and also an update to the redline library our fix for ssh256 headers

- craigwblake/redline#157
breskeby added a commit to elastic/elasticsearch that referenced this pull request Aug 18, 2021
This updates the nebula ospackage plugin to 8.6.1 that includes
a our provided PRs:

- nebula-plugins/gradle-ospackage-plugin#402
- nebula-plugins/gradle-ospackage-plugin#400
- nebula-plugins/gradle-ospackage-plugin#397

and also an update to the redline library our fix for ssh256 headers

- craigwblake/redline#157
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Dec 20, 2021
This updates the nebula ospackage plugin to 8.6.1 that includes
a our provided PRs:

- nebula-plugins/gradle-ospackage-plugin#402
- nebula-plugins/gradle-ospackage-plugin#400
- nebula-plugins/gradle-ospackage-plugin#397

and also an update to the redline library our fix for ssh256 headers

- craigwblake/redline#157
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this pull request Dec 20, 2021
This updates the nebula ospackage plugin to 8.6.1 that includes
a our provided PRs:

- nebula-plugins/gradle-ospackage-plugin#402
- nebula-plugins/gradle-ospackage-plugin#400
- nebula-plugins/gradle-ospackage-plugin#397

and also an update to the redline library our fix for ssh256 headers

- craigwblake/redline#157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants