This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
PLATFORMINFRA-218: always recreate csr #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bullet1337
force-pushed
the
PLATFORMINFRA-218
branch
from
d23e518 to
dea283a
Compare
syndicut
suggested changes
Apr 5, 2024
agent/registration/csr.go
Outdated
| @@ -10,6 +10,8 @@ import ( | |||
| "crypto/x509/pkix" | |||
| "encoding/pem" | |||
| "fmt" | |||
| "k8s.io/apimachinery/pkg/api/errors" | |||
There was a problem hiding this comment.
nit: move imports to next block
| @@ -1,4 +1,4 @@ | |||
| ARG BASE_IMAGE=ubuntu:20.04 | |||
| ARG BASE_IMAGE=ubuntu:22.04 | |||
There was a problem hiding this comment.
Is it absolutely neccesary?
There was a problem hiding this comment.
yep, it must be the same as local where is binary was built. otherwise there is a problem with libc version
bullet1337
force-pushed
the
PLATFORMINFRA-218
branch
from
dea283a to
d6049f9
Compare
syndicut
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nebius.atlassian.net/browse/PLATFORMINFRA-218