Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immutable field validation error when a sub-schema is not Pydantic #2797

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

kenafoster
Copy link
Contributor

Reference Issues or PRs

Fixes #2767

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Deploy Nebari with a configuration that includes an "overrides" or "values" block whose structure is not defined in the schema (this occurs when passing values to Helm charts). One example is:

jupyterhub:
  overrides:
    singleuser:
      extraEnv:
        ENV: "test"

Change the value of the "ENV" key and redeploy. (Nebari 2024.9.1 would error out)

Any other comments?

@Adam-D-Lewis
Copy link
Member

LGTM!

Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kenafoster!

@Adam-D-Lewis Adam-D-Lewis merged commit 55094c3 into main Oct 28, 2024
28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the 2767-immutable-fields branch October 28, 2024 16:32
viniciusdc pushed a commit that referenced this pull request Oct 30, 2024
#2797)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - 2024.9.1 Immutable Field Check Appears to Fail for Certain Schema Types
2 participants