Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to add overrides to jhub-apps config #2754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ability to add overrides to jhub-apps config #2754

wants to merge 2 commits into from

Conversation

aktech
Copy link
Member

@aktech aktech commented Oct 4, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2753

Documentation PR: nebari-dev/nebari-docs#534

This would be specially be useful to modify things like these:
nebari-dev/jhub-apps#499

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@aktech aktech marked this pull request as ready for review October 7, 2024 07:59
@aktech aktech mentioned this pull request Oct 8, 2024
Open
18 tasks
@aktech aktech mentioned this pull request Oct 10, 2024
Open
18 tasks
Adam-D-Lewis
Adam-D-Lewis approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adam-D-Lewis
Adam-D-Lewis approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viniciusdc viniciusdc added this to the 2024.10.1 release milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-D-Lewis Adam-D-Lewis Adam-D-Lewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: New 🚦
Milestone
2024.10.1 release
Development

Successfully merging this pull request may close these issues.

[ENH] - Add ability to override jhub-apps configuration
3 participants
@aktech @Adam-D-Lewis @viniciusdc