Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cypress remaining tests/files #2672

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

closes #2337

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

sorry for the PR duplicates

Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So have all the cypress tests been converted to playwright already or are we still missing any? LGTM!

@viniciusdc
Copy link
Contributor Author

So have all the cypress tests been converted to playwright already or are we still missing any?

All the tests have been migrated, and integrated as part of #2644

@viniciusdc viniciusdc merged commit 27b70eb into nebari-dev:develop Aug 30, 2024
9 of 10 checks passed
@viniciusdc viniciusdc deleted the 2337-remove-cypress branch August 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Remove files related to cypress
2 participants