Add shellcheck support (config, workflow to detect/not fix) and address some warnings #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defined in POSIX sh (according to shellcheck) Also made script executable since it is a script
left unused YELLOW to simplify possible use later. That command construct looks reliable enough to not care much
I guess it is unlikely that names would have spaces in them but shellcheck generally right on such a recommendation and with mapfile it would be more robust.
…nings
=== Do not change lines below ===
{
"chain": [],
"cmd": "sed -i -e '/# shellcheck disable.*/d' scripts/aws-force-destroy.sh",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-shellcheck
branch
from
64f48c3
to
7f526b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More about shellcheck https://www.shellcheck.net/ .
CI workflow has 'permissions' set only to 'read' so also should be safe.
Individual commits should have more of description. One of the "largest" changes is explicit specification to use
bashinstead of some generic POSIX shell due to use ofecho -ewhich according to shellcheck is not guaranteed to be supported by a POSIX shell... e.g. indash:TODOs