Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check before iterating over spec templates #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrix58
Copy link

@patrix58 patrix58 commented Jun 3, 2024

Fixes an issue encountered while running a Nebari v2024.5.1 on Kubernetes v1.23
image

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

We tested it on our cloud with building a custom image on our docker registry and referencing that image in the Nebari deployment configuration.
We plan to reference the official image again in the future as soon as this change is being released.

Documentation

Not documented, non breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant