Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bokeh>=3.0 #93

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use bokeh>=3.0 #93

merged 1 commit into from
Nov 9, 2023

Conversation

rsignell
Copy link
Contributor

@rsignell rsignell commented Nov 7, 2023

bokeh<3 was pinned during a period when the latest holoviz tools didn't work with bokeh 3. But then have worked with bokeh>=3 for a number of months now. Without this fix, the dask dashboard will remain broken

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

bokeh<3 was pinned during a period when the latest holoviz tools didn't work with bokeh 3.  But then have worked with bokeh>=3 for a number of months now.  Without this fix, the dask dashboard will remain broken
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rsignell!

@iameskild iameskild merged commit 7ab8166 into nebari-dev:main Nov 9, 2023
5 checks passed
@rsignell rsignell deleted the patch-1 branch November 9, 2023 08:17
@rsignell
Copy link
Contributor Author

rsignell commented Nov 9, 2023

@iameskild, thanks so much! Looking at the container tags, that resulted from merging this PR, can I just edit my nebari config and replace

default_images:
  jupyterhub: quay.io/nebari/nebari-jupyterhub:2023.10.1
  jupyterlab: quay.io/nebari/nebari-jupyterlab:2023.10.1
  dask_worker: quay.io/nebari/nebari-dask-worker:2023.10.1

with

default_images:
  jupyterhub: quay.io/nebari/nebari-jupyterhub:main-7ab8166-20231109
  jupyterlab: quay.io/nebari/nebari-jupyterlab:main-7ab8166-20231109
  dask_worker: quay.io/nebari/nebari-dask-worker:main-7ab8166-20231109

and let the github actions work their magic?

@iameskild
Copy link
Member

@rsignell that's correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants