Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-lfs to jupyterlab base image #90

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add git-lfs to jupyterlab base image #90

merged 1 commit into from
Sep 28, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Closes #88

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@aktech
Copy link
Member

aktech commented Sep 28, 2023

Any reason why we shouldn't get this from conda: https://anaconda.org/conda-forge/git-lfs/

@iameskild
Copy link
Member Author

@aktech I added git-lfs to the environment.yaml so it should be pulling from conda-forge right?

@aktech
Copy link
Member

aktech commented Sep 28, 2023

Ah, I misread that as apt packages list

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aktech aktech merged commit c4f6c5c into main Sep 28, 2023
11 checks passed
@aktech aktech deleted the add_git_lfs branch September 28, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Add git-lfs to base image
2 participants