Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jupyter-scheduler to v2.7.0 #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arjxn-py
Copy link

@arjxn-py arjxn-py commented Jul 2, 2024

Reference Issues or PRs

This PR updates the jupyter-scheduler version to v2.7.0, which addresses the issue tracked in jupyter-server/jupyter-scheduler#519.
Also related to nebari-dev/nebari#2548

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@arjxn-py arjxn-py marked this pull request as draft July 2, 2024 23:05
@arjxn-py
Copy link
Author

arjxn-py commented Jul 8, 2024

Hi @marcelovilla, I was able to build the docker image using Dockerfile.jupyterlab as #166 was the issue with all the associated bash file's line endings.
I then wanted to locally reproduce https://www.nebari.dev/docs/tutorials/jupyter-scheduler/, and tried running the docker image but it exits instantly. Is there any specific command that I need to run?

Plus I'm not sure where CI covers this change, I'd be happy to know as it is passing.

@arjxn-py arjxn-py marked this pull request as ready for review July 8, 2024 11:03
@arjxn-py arjxn-py requested a review from krassowski July 20, 2024 18:14
@viniciusdc
Copy link
Contributor

viniciusdc commented Jul 23, 2024

@krassowski is this expected to be in the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants