Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jupyterlab-new-launcher to 0.4.1 #150

Merged
merged 2 commits into from
May 28, 2024
Merged

Upgrade jupyterlab-new-launcher to 0.4.1 #150

merged 2 commits into from
May 28, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 27, 2024 •
edited
Loading

Reference Issues or PRs

Follow-up to #147, includes a fix for the last issue that we wanted to address before shipping (nebari-dev/jupyterlab-launchpad#31)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski marked this pull request as ready for review May 27, 2024 15:41
@krassowski
Copy link
Member Author

@marcelovilla I would love to get this in too before the final release

marcelovilla
marcelovilla approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @krassowski! Meant to review it yesterday but completely forgot about it. Thank you!

@krassowski krassowski merged commit bbf7267 into main May 28, 2024
11 checks passed
@krassowski krassowski deleted the jupyterlab-new-launcher-0.4.1 branch May 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @marcelovilla