Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyterlab-new-launcher extension #139

Merged

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

(for now this is a draft for testing the image including jupyterlab-new-launcher, and also for awareness)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

TBD

@krassowski krassowski added the type: enhancement 💅🏼 New feature or request label Apr 26, 2024
@krassowski krassowski marked this pull request as ready for review May 7, 2024 14:19
@krassowski
Copy link
Member Author

Resolved conflicts. I think v0.3.0 should be mature enough to include in the next pre-release.

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @krassowski!

@krassowski krassowski merged commit c41a7de into nebari-dev:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants