Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adapter optional to support in-memory cases #5

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Make adapter optional to support in-memory cases #5

merged 1 commit into from
Jan 9, 2021

Conversation

kibertoad
Copy link
Contributor

fixes #4

@codecov-io
Copy link

Codecov Report

Merging #5 (5b03345) into master (63e48a5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           14        16    +2     
=========================================
+ Hits            14        16    +2     
Impacted Files Coverage Δ
plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e48a5...5b03345. Read the comment docs.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@simoneb simoneb merged commit 9eedf14 into nearform:master Jan 9, 2021
@kibertoad kibertoad deleted the feature/optional-adapter branch January 9, 2021 20:18
@kibertoad
Copy link
Contributor Author

@simoneb Thank you for the quick review! Any chance you could publish new version in the nearby future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter should be optional
3 participants