Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ledger Known Issues and Solution #414

Closed
wants to merge 1 commit into from

Conversation

gagdiez
Copy link

@gagdiez gagdiez commented Aug 22, 2022

Description

Using Ledger with bundler results in some simple-to-fix issues. I have added the issues to the main README.md for high visibility, as well as the proposed solution.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@gagdiez gagdiez mentioned this pull request Aug 22, 2022
@kujtimprenkuSQA
Copy link
Contributor

Hey, @gagdiez thank you for submitting this PR.

I think this issue is related only to the ledger package when a dApp uses parcel for bundling it would be better to add the Known Issue there, we've already done it on dev branch.

PR: #413
Dev Branch (ledger readme): https://github.com/near/wallet-selector/tree/dev/packages/ledger#known-issues

Could you please follow the contribution guideline here, we do not push to main unless it's for a release:
https://github.com/near/wallet-selector/blob/main/CONTRIBUTING.md#branching

@gagdiez gagdiez closed this Aug 23, 2022
@kujtimprenkuSQA kujtimprenkuSQA deleted the gagdiez/readme-known-issues branch August 27, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants