Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPLT-1019] feat: store debug list in LocalStorage #90

Merged
merged 2 commits into from
Jun 2, 2023
Merged

[DPLT-1019] feat: store debug list in LocalStorage #90

merged 2 commits into from
Jun 2, 2023

Conversation

roshaans
Copy link
Contributor

@roshaans roshaans commented Jun 1, 2023 •
edited
Loading

Store Debug List in Local Storage so reloading and tab switching persists the list.

@roshaans roshaans marked this pull request as ready for review June 1, 2023 20:27
morgsmccauley
morgsmccauley reviewed Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@morgsmccauley morgsmccauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to add the issue key to the PR title

frontend/src/components/Editor/Editor.js Outdated Show resolved Hide resolved
frontend/src/components/Editor/Editor.js Outdated Show resolved Hide resolved
@roshaans roshaans requested a review from morgsmccauley June 1, 2023 21:28
morgsmccauley
morgsmccauley approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@morgsmccauley morgsmccauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but PR title still needs to be updated 😅

@roshaans roshaans changed the title feat: store debug list in LocalStorage [DPLT-1019] feat: store debug list in LocalStorage Jun 2, 2023
@roshaans roshaans merged commit cf8274c into main Jun 2, 2023
@roshaans roshaans deleted the roshaan/store-debug-list-localstorage branch June 2, 2023 13:21
@roshaans roshaans mentioned this pull request Jun 6, 2023
Merged
gabehamilton pushed a commit that referenced this pull request Jun 26, 2023
@roshaans @gabehamilton
[DPLT-1019] feat: store debug list in LocalStorage (#90)
4296b11
@morgsmccauley morgsmccauley mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgsmccauley morgsmccauley morgsmccauley approved these changes

@gabehamilton gabehamilton Awaiting requested review from gabehamilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roshaans @morgsmccauley