feat: Add metrics to Block Streamer #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/block-streamer-metrics
branch
from
dd4ba32 to
10561b9
Compare
morgsmccauley
changed the title
morgsmccauley
commented
Feb 23, 2024
| .with(tracing_subscriber::EnvFilter::from_default_env()) | ||
| .init(); | ||
|
|
||
| let redis_url = std::env::var("REDIS_URL").expect("REDIS_URL is not set"); | ||
| let server_port = std::env::var("SERVER_PORT").expect("SERVER_PORT is not set"); | ||
| let grpc_port = std::env::var("GRPC_PORT").expect("GRPC_PORT is not set"); |
There was a problem hiding this comment.
Will also make this change in Terraform
morgsmccauley
force-pushed
the
feat/block-streamer-metrics
branch
from
10561b9 to
5609feb
Compare
morgsmccauley
commented
Feb 23, 2024
|
|
||
| pub fn last_processed_block_key(&self) -> String { | ||
| // TODO: rename to `last_processed_block` | ||
| format!("{}:last_published_block", self.get_full_name()) |
There was a problem hiding this comment.
"published" should mean it actually got added to the Redis Stream
darunrs
approved these changes
Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following metrics to Block Streamer:
LAST_PROCESSED_BLOCK- height of last block seen, will be used to calculate the lag from tip of networkPROCESSED_BLOCKS_COUNT- count of blocks seen, used to calculate BPSPUBLISHED_BLOCKS_COUNT- count of blocks published to Redis Stream, to determine whether the block stream is publishing messagesLOGS_COUNT- count logs by level, so we can alert on number of error logs etc.I've also slightly refactored
RedisClientto support this change.