fix: view and monaco glyph interactions with debug and diffviedw

[Kevin101Zhang]

Logic fix for handling monaco glyph mounting.

Originally it will error on diffView/debug mode due to rendering of unmounted glyphs.

Video post fix:
https://www.loom.com/share/dd797612590d4f12a27e7216ab009b68?sid=4ec944fd-e718-4851-b231-4339ffab5bd8

[darunrs]

What purpose does this particular delta decoration actually do? Is this a leftover from when you were doing the green box? If so, can we just remove it?

Also, I believe WillMount is only done on init.

I think there's a small bug with context.db where on initial reload, it doesn't set the types. You have to change tabs to get it to load, or click the button. This was because of a race condition where WillMount may be done before the editor is actually available. My guess is that is the cause of the error, not that it's setting decorations that don't exist.

Maybe you can experiment with that later. But its best to do any monaco things when we're sure it's completely initialized.

[Kevin101Zhang]

Its necessary to mount the glyph here.
We do this to grab the decoration that takes a shape ['W;3'] and the monaco editor ref.
Note: the decoration letter and number changes everytime
When we run parseGlyph it is overwriting the one decoration in line

monacoEditorRef.current.deltaDecorations( [decorations], [ { range: new monaco.Range(startLine, startColumn, endLine, endColumn), options: { isWholeLine: true, glyphMarginClassName: error ? "glyphError" : "glyphSuccess", glyphMarginHoverMessage: { value: displayedError }, }, }, ] );

The other option is to create the the decoration for the first time in parseGlyphError. I tried this approach but it makes the code less readable since we are instantiating the glyph here here.

What can be done is the code onMount can be shortened without the key/value pairs in the options.

if (!diffView) {
const decorations = editor.deltaDecorations([],
[
{
range: new monaco.Range(1, 1, 1, 1),
options: {},
},
]
);
monacoEditorRef.current = editor;
setDecorations(decorations);
}

[Kevin101Zhang]

Will go ahead and push the version without options. Doing this will keep the behavior the same. Will look into the type issue in a different branch

[darunrs]

A comment on the fix.

[darunrs]

Ok sounds good!