Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent skipping blocks from Redis Stream #558

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Feb 13, 2024

xread returns messages after the provided ID, there's no need to increment the ID ourselves. If we increment to an ID that actually exists within the stream, the message will be skipped permanently. e.g. we have messages 1-0 and 1-1, on first read we get 1-0, we increment to 1-1, then on the second read we get nothing.

@morgsmccauley morgsmccauley self-assigned this Feb 13, 2024
@morgsmccauley morgsmccauley marked this pull request as ready for review February 13, 2024 20:38
@morgsmccauley morgsmccauley requested a review from a team as a code owner February 13, 2024 20:38
@morgsmccauley morgsmccauley added bug Something isn't working component: Runner labels Feb 13, 2024
@morgsmccauley morgsmccauley merged commit c8ff7d1 into main Feb 13, 2024
3 checks passed
@morgsmccauley morgsmccauley deleted the fix/skipped-blocks branch February 13, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Runner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants