Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Dockerfile for Coordinator V2 #519

Merged
merged 3 commits into from
Jan 24, 2024
Merged

feat: Add Dockerfile for Coordinator V2 #519

merged 3 commits into from
Jan 24, 2024

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Jan 23, 2024 •
edited
Loading

No description provided.

@morgsmccauley morgsmccauley changed the base branch from main to feat/allowlist January 23, 2024 01:35
@morgsmccauley morgsmccauley force-pushed the feat/coordinator-infra branch from d4c536a to 4b84ca2 Compare January 23, 2024 01:51
@morgsmccauley morgsmccauley changed the title feat/coordinator infra feat: Add Dockerfile for Coordinator V2 Jan 23, 2024
@morgsmccauley morgsmccauley linked an issue Jan 23, 2024 that may be closed by this pull request
Setup infra for Coordinator V2 #455
Closed
@morgsmccauley morgsmccauley marked this pull request as ready for review January 23, 2024 02:41
@morgsmccauley morgsmccauley requested a review from a team as a code owner January 23, 2024 02:41
darunrs
darunrs approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you also add Coordinator V2 to the compose file?

@morgsmccauley
Copy link
Collaborator Author

LGTM! Could you also add Coordinator V2 to the compose file?

Done 👍🏼

Base automatically changed from feat/allowlist to main January 24, 2024 20:47
@morgsmccauley morgsmccauley force-pushed the feat/coordinator-infra branch from 9973ec6 to e3d2075 Compare January 24, 2024 20:49
@morgsmccauley morgsmccauley merged commit 32d6fa9 into main Jan 24, 2024
4 checks passed
@morgsmccauley morgsmccauley deleted the feat/coordinator-infra branch January 24, 2024 20:51
@darunrs darunrs mentioned this pull request Feb 1, 2024
Merged
@morgsmccauley morgsmccauley mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darunrs darunrs darunrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup infra for Coordinator V2
2 participants
@morgsmccauley @darunrs