Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure array is returned to Promise.all #504

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Jan 16, 2024

fetchShardsPromises is used within Promise.all to fetch all shards simultaneously. The async modifier means this function returns a Promise. Promise.all complains since it's passed a Promise rather than an Array.

This PR removes the unnecessary async modifier so it works with Promise.all

@morgsmccauley morgsmccauley requested a review from a team as a code owner January 16, 2024 20:08
@morgsmccauley morgsmccauley merged commit 13f7094 into main Jan 16, 2024
@morgsmccauley morgsmccauley deleted the fix/block-server-shards branch January 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant