DPLT-1118 Parallelize stream processing with worker threads #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/worker-threads
branch
from
f2d5da8 to
6983e21
Compare
morgsmccauley
force-pushed
the
feat/worker-threads
branch
2 times, most recently
from
2d69c4d to
71be610
Compare
morgsmccauley
force-pushed
the
feat/worker-threads
branch
3 times, most recently
from
42ecd8c to
e82e2ef
Compare
morgsmccauley
force-pushed
the
feat/worker-threads
branch
from
e82e2ef to
49a3a4b
Compare
morgsmccauley
commented
Sep 15, 2023
| name: 'queryapi_runner_execution_duration_milliseconds', | ||
| help: 'Time taken to execute an indexer function', | ||
| labelNames: ['indexer', 'type'], | ||
| }); | ||
|
|
||
| export const METRICS = { |
There was a problem hiding this comment.
Exporting as a single group allows us to automatically create associated types, see: Metric in StreamHandler
morgsmccauley
commented
Sep 15, 2023
| import { type Message } from './types'; | ||
| import { METRICS } from '../metrics'; | ||
|
|
||
| export default class StreamHandler { |
There was a problem hiding this comment.
This is a wrapper around Worker which will (eventually) expose a nicer API to the consumer, meaning they don't have to deal with sending/receiving messages.
morgsmccauley
commented
Sep 15, 2023
| @@ -0,0 +1,9 @@ | |||
| import { type METRICS } from '../metrics'; | |||
There was a problem hiding this comment.
Shared types between the worker and api (StreamHandler)
morgsmccauley
commented
Sep 15, 2023
|
|
||
| const unprocessedMessages = await redisClient.getUnprocessedStreamMessages(streamKey); | ||
|
|
||
| parentPort?.postMessage({ |
There was a problem hiding this comment.
Metrics written directly from another thread won't be picked up by the main thread, where the metrics server aggregates and exposes them. We therefore need to send the metric to the main thread and write them there.
morgsmccauley
force-pushed
the
feat/worker-threads
branch
from
f581c94 to
6cfc43c
Compare
morgsmccauley
changed the title
morgsmccauley
force-pushed
the
feat/worker-threads
branch
from
fdb019d to
6cfc43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parallelises indexer processing by moving them to their own threads. This means that CPU is no longer shared across all indexers on the single thread. I/O is still shared across all threads, but shouldn't be an issue as this isn't the limiting factor of Runner.