Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused transaction cache #182

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

morgsmccauley
Copy link
Collaborator

No description provided.

@morgsmccauley morgsmccauley requested a review from a team as a code owner August 17, 2023 02:59
Copy link
Contributor

@roshaans roshaans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@morgsmccauley morgsmccauley merged commit cfb7f46 into main Aug 17, 2023
@morgsmccauley morgsmccauley deleted the chore/remove-tx-cache branch August 17, 2023 19:32
@gabehamilton
Copy link
Collaborator

You could also replace the outcomes_reducer with outcomes_reducer sync if you like. It was async in anticipation of using the transaction cache. If you do that there are a couple tests in the async file that could be moved (and slightly updated) to the sync version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants