DPLT-1084 Add support for Runner infrastructure #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
DPLT-1084-provision-infra-for-redis-handler
branch
3 times, most recently
from
4fe8d93 to
a875e94
Compare
morgsmccauley
force-pushed
the
DPLT-1084-provision-infra-for-redis-handler
branch
from
a875e94 to
7527250
Compare
morgsmccauley
commented
Aug 6, 2023
| database: process.env.PG_ADMIN_DATABASE, | ||
| host: process.env.PG_HOST, | ||
| port: Number(process.env.PG_PORT), | ||
| user: process.env.PGUSER, |
There was a problem hiding this comment.
Now using node-postgres & Postgres specified environment variables, these don't actually need to be defined, but I'm just doing it for explicitness.
morgsmccauley
commented
Aug 6, 2023
| @@ -39,7 +39,7 @@ export default class Indexer { | |||
| this.network = network; | |||
| this.deps = { | |||
| fetch, | |||
| s3: new AWS.S3({ region: process.env.REGION }), | |||
There was a problem hiding this comment.
This env var has been changed to AWS_REGION, which is automatically pulled in from the environment.
morgsmccauley
force-pushed
the
DPLT-1084-provision-infra-for-redis-handler
branch
from
51ad3be to
6ddc549
Compare
morgsmccauley
commented
Aug 6, 2023
| "prettier": "^3.0.0", | ||
| "ts-jest": "^29.1.1", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^5.1.6" | ||
| }, | ||
| "dependencies": { | ||
| "@near-lake/primitives": "^0.1.0", | ||
| "pluralize": "^8.0.0", |
There was a problem hiding this comment.
Dev dependencies are stripped from the docker build, and this was incorrectly placed there.
morgsmccauley
changed the title
morgsmccauley
changed the title
|
Merging as I need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various changes to support the new Runner infra. I've added comments inline to provide context to the changes.