Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPLT-1044 Change HISTORICAL dimension to EXECUTION_TYPE #130

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Jul 16, 2023

Dimensions must be of string type, so labelling whether the function if historical or real-time makes more sense here.

@morgsmccauley morgsmccauley requested a review from a team as a code owner July 16, 2023 21:05
@morgsmccauley morgsmccauley force-pushed the DPLT-1044-fix-custom-metrics branch from 5076f52 to 678934f Compare July 16, 2023 21:05
@morgsmccauley morgsmccauley force-pushed the DPLT-1044-fix-custom-metrics branch from 678934f to ddc407d Compare July 16, 2023 21:08
@morgsmccauley morgsmccauley changed the title DPLT-1044 Change HISTORICAL metric dimension to string DPLT-1044 Change HISTORICAL dimension to EXECUTION_TYPE Jul 16, 2023
@morgsmccauley morgsmccauley merged commit 9a657a3 into main Jul 16, 2023
@morgsmccauley morgsmccauley deleted the DPLT-1044-fix-custom-metrics branch July 16, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant