Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/frontend #128

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Docs/frontend #128

merged 4 commits into from
Jul 21, 2023

Conversation

roshaans
Copy link
Contributor

No description provided.

@roshaans roshaans requested a review from a team as a code owner July 14, 2023 20:11
frontend/README.md Show resolved Hide resolved

You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome!
After that, head to `near.org/flag` and enter the URL you got from the first step. If you have not changed any configurations then the default should be `http://127.0.0.1:3030`
Copy link
Collaborator

@darunrs darunrs Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Would be nice to have a comment below explaining what that does specifically. Something like:

This changes the gateway to consume the widget from the URL provided instead of from on-chain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, a more in-depth explanation would be really helpful here. Maybe you could have a section which explains; how widgets are sourced at a high-level and that bos-loader is needed to bypass the above


To learn more about Next.js, take a look at the following resources:
```bash
bos-loader dev-queryapi.dataplatform.near --path widgets/src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an npm script?

Suggested change
bos-loader dev-queryapi.dataplatform.near --path widgets/src
yarn serve-widgets

frontend/README.md Show resolved Hide resolved

You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome!
After that, head to `near.org/flag` and enter the URL you got from the first step. If you have not changed any configurations then the default should be `http://127.0.0.1:3030`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After that, head to `near.org/flag` and enter the URL you got from the first step. If you have not changed any configurations then the default should be `http://127.0.0.1:3030`
After that, head to `near.org/flags` and enter the URL you got from the first step. If you have not changed any configurations then the default should be `http://127.0.0.1:3030`


You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome!
After that, head to `near.org/flag` and enter the URL you got from the first step. If you have not changed any configurations then the default should be `http://127.0.0.1:3030`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, a more in-depth explanation would be really helpful here. Maybe you could have a section which explains; how widgets are sourced at a high-level and that bos-loader is needed to bypass the above

@roshaans roshaans merged commit 0742afe into main Jul 21, 2023
@roshaans roshaans deleted the docs/frontend branch July 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants