Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPLT-1042] Add support for backend only mutations from Runner #109

Merged
merged 3 commits into from
Jun 28, 2023
Merged

[DPLT-1042] Add support for backend only mutations from Runner #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f95b71d
feat: Add support for backend only mutations from Runner
morgsmccauley Jun 26, 2023
331d8d2
test: Ensure backend only mutation headers are sent to hasura
morgsmccauley Jun 27, 2023
dac967a
feat: Prevent assuming of `admin` role
morgsmccauley Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hasura-authentication-service/src/services.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@ pub(crate) async fn auth(req: HttpRequest) -> impl Responder {
None => std::env::var("DEFAULT_HASURA_ROLE").unwrap(),
};

if role_header == "admin" {
Copy link
Collaborator Author

@morgsmccauley morgsmccauley Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to this, it was possible to assume the admin role by specifying it on the headers. This disables that functionality so that it is not possible to workaround the Backend Only Mutations.

Note that assuming admin is still possible by passing the specifying the X-Hasura-Admin-Secret header.

return HttpResponse::Unauthorized().finish();
}

HttpResponse::Ok().json(AuthResponse { role_header })
}
Loading