-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default transaction pool size limit to 100MB. #9172
Set default transaction pool size limit to 100MB. #9172
Conversation
@Akashin At a minimum it should be mentioned in the release notes. Please consider creating a Jira task. We don't have a comprehensive documentation for |
I've added longer documentation in the field docstring. I wasn't able to find where exactly I need to create a task in Jira, is this a part of some release process? |
39e74fa
to
950a42b
Compare
This PR enables the limit discussed in #3284. I've [considered](https://near.zulipchat.com/#narrow/stream/297873-pagoda.2Fnode/topic/Adding.20a.20new.20field.20to.20config.2Ejson/near/358955785) another approach to rolling this out by changing the value in `config.json` distributed through S3, but that would require more work both on our side and on validators without adding much benefit. Specifically, I've checked that we have a good safety margin here, as over the last month on the testnet, the max size of the transaction pool on the validators was < 40 KB: https://nearinc.grafana.net/goto/AhZFN__4R?orgId=1. @nikurt What would be a good place to document this field for validators? I saw https://near-nodes.io/, but couldn't find the appropriate section there.
This PR enables the limit discussed in #3284.
I've considered another approach to rolling this out by changing the value in
config.json
distributed through S3, but that would require more work both on our side and on validators without adding much benefit.Specifically, I've checked that we have a good safety margin here, as over the last month on the testnet, the max size of the transaction pool on the validators was < 40 KB: https://nearinc.grafana.net/goto/AhZFN__4R?orgId=1.
@nikurt What would be a good place to document this field for validators? I saw https://near-nodes.io/, but couldn't find the appropriate section there.