feat: Add per shard granularity for validator info #8934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikurt: do you have the bandwidth to review this please? |
VanBarbascu
force-pushed
the
per_shard_granularity_for_validator_info
branch
from
18dd1db to
7b04386
Compare
nikurt
approved these changes
Apr 20, 2023
| pub(crate) static VALIDATORS_CHUNKS_PRODUCED_BY_SHARD: Lazy<IntGaugeVec> = Lazy::new(|| { | ||
| try_create_int_gauge_vec( | ||
| "near_validators_chunks_produced_by_shard", | ||
| "Number of chunks produced by a validator", |
There was a problem hiding this comment.
Same description as the metric above.
Does this deprecate the other metric?
There was a problem hiding this comment.
Only if we can do sum by account_id in Graphana/ Prometheus. @vlad-kopcil wdyt?
There was a problem hiding this comment.
From my searches online, you can do it. This means that we can deprecate the previous field. We will not do it in this PR because we need to figure out where it is used and migrate to the new metric.
Count the number chunks produced and expected to be produced so far for each individual shard. When one chunk producer is assigned to multiple shards, we can see the production / expected for each of the shard. Tested on an RPC node in mainnet. Paste from the metrics tab of a node in mainnet. [link](https://gist.github.com/VanBarbascu/26dc011291df7f128d609c8457d57469)
VanBarbascu
force-pushed
the
per_shard_granularity_for_validator_info
branch
from
7b04386 to
8f284ee
Compare
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
Count the number chunks produced and expected to be produced so far for each individual shard. When one chunk producer is assigned to multiple shards, we can see the production / expected for each of the shard. Tested on an RPC node in mainnet. Paste from the metrics tab of a node in mainnet. [link](https://gist.github.com/VanBarbascu/26dc011291df7f128d609c8457d57469)
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
Count the number chunks produced and expected to be produced so far for each individual shard. When one chunk producer is assigned to multiple shards, we can see the production / expected for each of the shard. Tested on an RPC node in mainnet. Paste from the metrics tab of a node in mainnet. [link](https://gist.github.com/VanBarbascu/26dc011291df7f128d609c8457d57469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count the number chunks produced and expected to be produced so far for each individual shard.
When one chunk producer is assigned to multiple shards, we can see the production / expected for each of the shard.
Tested on an RPC node in mainnet.
Paste from the metrics tab of a node in mainnet. link