cleanup: Removing RuntimeConfigView -> RuntimeConfig #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
commented
Mar 21, 2023
aborg-dev
force-pushed
the
remove_from_view
branch
from
59792a0
to
18dcaf8
Compare
aborg-dev
force-pushed
the
remove_from_view
branch
from
18dcaf8
to
bf0fd22
Compare
khorolets
approved these changes
Apr 24, 2023
Longarithm
approved these changes
Apr 24, 2023
That sounds important :) |
aborg-dev
force-pushed
the
remove_from_view
branch
from
1e5232c
to
21cef92
Compare
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
In #8426 this conversion became lossy due to the introduction of Compute Costs. This raised the question of whether this conversion is needed at all. I've found one place in the Indexer code that uses it and replaced it with a direct lookup for config from `RuntimeConfigStore`. As a part of this I've also simplified some code in the indexer. This should fix the failing nayduck test #8967
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
In #8426 this conversion became lossy due to the introduction of Compute Costs. This raised the question of whether this conversion is needed at all. I've found one place in the Indexer code that uses it and replaced it with a direct lookup for config from `RuntimeConfigStore`. As a part of this I've also simplified some code in the indexer. This should fix the failing nayduck test #8967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8426 this conversion became lossy due to the introduction of Compute Costs. This raised the question of whether this conversion is needed at all. I've found one place in the Indexer code that uses it and replaced it with a direct lookup for config from
RuntimeConfigStore. As a part of this I've also simplified some code in the indexer.This should fix the failing nayduck test #8967